Switch to official YAML extension by default#1678
Open
krystof-k wants to merge 26 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tion Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
documentation
Signed-off-by: Kryštof Korb <krystof@korb.cz>
marcoroth
reviewed
May 6, 2026
marcoroth
left a comment
marcoroth
left a comment
Owner
There was a problem hiding this comment.
Hey @krystof-k, thanks for the pull request.
I have been following the convention established by most Ruby tools and configuration files that also Rails ships with, which all use .yml.
So I'm not sure if we should be using .yaml, as that might be unusual and unexpected for most users.
Author
|
Hi @marcoroth, so at least someone needs to have it right ;) Jokes aside, fair point — I understand the Ruby/Rails convention around Whether Herb should prefer |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…hFromProjectPath
The bare require('fs') call was preserved verbatim in the ESM bundle
(rollup format 'esm', fs external), so any Node ESM consumer constructing
a Config without an explicit configPath crashed with
"ReferenceError: require is not defined".
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…path Status bar, config views, quick-fix titles, warning-popup buttons, and version-mismatch warnings hardcoded .herb.yaml even when the loaded config file was the legacy .herb.yml, pointing users at a file that doesn't exist in their project. Messages that direct the user to the config file now use the basename of the resolved path; messages that only describe configuration state drop the filename. Creation flows intentionally keep the .herb.yaml default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…essages Messages like "disabled in .herb.yaml" named the wrong file in projects using legacy .herb.yml — and following "set formatter.enabled: true in .herb.yaml" literally would create a second config file that shadows the existing one. Runtime messages now interpolate the loaded config's basename; only creation flows (--init tips, help text) keep the .herb.yaml default, and "No .herb.yaml found" becomes "No Herb config file found" since neither file exists at that point. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Discovery silently prefers .herb.yaml, so a stray second config file would shadow all settings in the other with no indication anywhere. The CLI now prints a warning when it finds more than one config file in the project root. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Love the work you're doing on Herb — it's a great tool and I'm enjoying using it!
I ran into a small friction point: when I created
.herb.yamlinstead of.herb.yml, it didn't work — it was actually actively rejected with an error asking me to rename it. Since.yamlis the official YAML extension, it should be the supported (and preferred) variant.This PR:
--initHope this absolutely unimportant but preventing-many-confusions change will be helpful!